[aes/sw] Load all-zero vector into PRNG buffer stage for masking off #22930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vogelpi
requested review from
rswarbrick,
nasahlpa and
antmarzam
and removed request for
alees24
The input masks are now taken from the PRNG buffer stage. This means after loading the magic seed into the PRNG and having the PRNG output the all-zero vector, the buffer stage needs to be updated as well. This can be achieved by triggering via a clearing operation of the data output registers. This resolves lowRISC#22917. Signed-off-by: Pirmin Vogel <[email protected]>
rswarbrick
approved these changes
May 2, 2024
| } | ||
| #endif | ||
| CHECK_DIF_OK(dif_aes_trigger(&aes, kDifAesTriggerDataOutClear)); |
There was a problem hiding this comment.
I notice that the equivalent line in aes_sca.c is skipped for EnglishBreakfast. Is putting this line outside of the if/endif intentional?
There was a problem hiding this comment.
Yes it is. Only aes_serial.c runs on English Breakfast (where we use a different way to 0 masks because there is no CSRNG). aes_sca.c only runs on the actual chip and the CW310/340 (because English Breakfast has just 1 UART whereas the uJSON communication needs 2 UARTs).
|
Thanks for your reviews. There are some CI FPGA failures but this is all spurious. The code in this PR is NOT run on the FPGA in any form in CI. I am thus merging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The input masks are now taken from the PRNG buffer stage. This means after loading the magic seed into the PRNG and having the PRNG output the all-zero vector, the buffer stage needs to be updated as well. This can be achieved by triggering via a clearing operation of the data output registers.
This resolves #22917.