Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test-triage] chip_sw_aes_masking_off fails after AES RTL changes #22917

Closed
antmarzam opened this issue May 1, 2024 · 1 comment · Fixed by #22930
Closed

[test-triage] chip_sw_aes_masking_off fails after AES RTL changes #22917

antmarzam opened this issue May 1, 2024 · 1 comment · Fixed by #22930
Assignees

Comments

@antmarzam
Copy link
Contributor

Hierarchy of regression failure

Block level

Failure Description

UVM_FATAL @ 3321.421894 us: (chip_sw_aes_masking_off_vseq.sv:162) [uvm_test_top.env.virtual_sequencer.chip_sw_aes_masking_off_vseq] Check failed state_init_share1 == '0 (261008556511606517935595337728332530022 [0xc45c6b6290143840c51c1bbea8020166] vs 0 [0x0]) Share 1 of the input not equal zero.

There's also a TL-UL failing assertion:
../src/lowrisc_tlul_common_0.1/rtl/tlul_assert.sv", 301: tb.dut.top_earlgrey.u_xbar_main.tlul_assert_host_rv_core_ibex__cored.gen_assert_final[1].noOutstandingReqsAtEndOfSim_A: started at 3321421894ps failed at 3321421894ps
Offending '((pend_req[1].pend == 1'b0) || $test$plusargs("disable_assert_final_checks"))'
UVM_ERROR @ 3321.421894 us: (tlul_assert.sv:301) [ASSERT FAILED] noOutstandingReqsAtEndOfSim_A

Steps to Reproduce

  • GitHub Revision: 0cb61fc7e7
  • dvsim invocation command to reproduce the failure, inclusive of build and run seeds:
    ./util/dvsim/dvsim.py hw/top_earlgrey/dv/chip_sim_cfg.hjson -i chip_sw_aes_masking_off --build-seed 29629349767786988748941369645310183062873507656225682712521573681396210883738 --fixed-seed 50872679030684457411525866978198029813162651732304102301881216380340976679238

Tests with similar or related failures

Fixed Seed 62014364074305549766088787075294037528818904623409476815904894661659903874324 was also failing

vogelpi added a commit to vogelpi/opentitan that referenced this issue May 2, 2024
The input masks are now taken from the PRNG buffer stage. This means
after loading the magic seed into the PRNG and having the PRNG output
the all-zero vector, the buffer stage needs to be updated as well.
This can be achieved by triggering via a clearing operation of the data
output registers.

This resolves lowRISC#22917.

22917Signed-off-by: Pirmin Vogel <[email protected]>
Signed-off-by: Pirmin Vogel <[email protected]>
vogelpi added a commit to vogelpi/opentitan that referenced this issue May 2, 2024
The input masks are now taken from the PRNG buffer stage. This means
after loading the magic seed into the PRNG and having the PRNG output
the all-zero vector, the buffer stage needs to be updated as well.
This can be achieved by triggering via a clearing operation of the data
output registers.

This resolves lowRISC#22917.

Signed-off-by: Pirmin Vogel <[email protected]>
@vogelpi
Copy link
Contributor

vogelpi commented May 2, 2024

I've now filed a PR to get this test going again, see #22930.

vogelpi added a commit to vogelpi/opentitan that referenced this issue May 2, 2024
The input masks are now taken from the PRNG buffer stage. This means
after loading the magic seed into the PRNG and having the PRNG output
the all-zero vector, the buffer stage needs to be updated as well.
This can be achieved by triggering via a clearing operation of the data
output registers.

This resolves lowRISC#22917.

Signed-off-by: Pirmin Vogel <[email protected]>
vogelpi added a commit that referenced this issue May 2, 2024
The input masks are now taken from the PRNG buffer stage. This means
after loading the magic seed into the PRNG and having the PRNG output
the all-zero vector, the buffer stage needs to be updated as well.
This can be achieved by triggering via a clearing operation of the data
output registers.

This resolves #22917.

Signed-off-by: Pirmin Vogel <[email protected]>
sameo pushed a commit to sameo/opentitan that referenced this issue Jun 10, 2024
The input masks are now taken from the PRNG buffer stage. This means
after loading the magic seed into the PRNG and having the PRNG output
the all-zero vector, the buffer stage needs to be updated as well.
This can be achieved by triggering via a clearing operation of the data
output registers.

This resolves lowRISC#22917.

Signed-off-by: Pirmin Vogel <[email protected]>
sameo pushed a commit to sameo/opentitan that referenced this issue Jun 10, 2024
The input masks are now taken from the PRNG buffer stage. This means
after loading the magic seed into the PRNG and having the PRNG output
the all-zero vector, the buffer stage needs to be updated as well.
This can be achieved by triggering via a clearing operation of the data
output registers.

This resolves lowRISC#22917.

Signed-off-by: Pirmin Vogel <[email protected]>
sameo pushed a commit to sameo/opentitan that referenced this issue Jun 10, 2024
The input masks are now taken from the PRNG buffer stage. This means
after loading the magic seed into the PRNG and having the PRNG output
the all-zero vector, the buffer stage needs to be updated as well.
This can be achieved by triggering via a clearing operation of the data
output registers.

This resolves lowRISC#22917.

Signed-off-by: Pirmin Vogel <[email protected]>
sameo pushed a commit to sameo/opentitan that referenced this issue Jun 10, 2024
The input masks are now taken from the PRNG buffer stage. This means
after loading the magic seed into the PRNG and having the PRNG output
the all-zero vector, the buffer stage needs to be updated as well.
This can be achieved by triggering via a clearing operation of the data
output registers.

This resolves lowRISC#22917.

Signed-off-by: Pirmin Vogel <[email protected]>
jadephilipoom pushed a commit to jadephilipoom/opentitan that referenced this issue Jun 17, 2024
The input masks are now taken from the PRNG buffer stage. This means
after loading the magic seed into the PRNG and having the PRNG output
the all-zero vector, the buffer stage needs to be updated as well.
This can be achieved by triggering via a clearing operation of the data
output registers.

This resolves lowRISC#22917.

Signed-off-by: Pirmin Vogel <[email protected]>
jadephilipoom pushed a commit to jadephilipoom/opentitan that referenced this issue Jun 17, 2024
The input masks are now taken from the PRNG buffer stage. This means
after loading the magic seed into the PRNG and having the PRNG output
the all-zero vector, the buffer stage needs to be updated as well.
This can be achieved by triggering via a clearing operation of the data
output registers.

This resolves lowRISC#22917.

Signed-off-by: Pirmin Vogel <[email protected]>
sameo pushed a commit to sameo/opentitan that referenced this issue Jun 17, 2024
The input masks are now taken from the PRNG buffer stage. This means
after loading the magic seed into the PRNG and having the PRNG output
the all-zero vector, the buffer stage needs to be updated as well.
This can be achieved by triggering via a clearing operation of the data
output registers.

This resolves lowRISC#22917.

Signed-off-by: Pirmin Vogel <[email protected]>
sameo pushed a commit to sameo/opentitan that referenced this issue Jun 17, 2024
The input masks are now taken from the PRNG buffer stage. This means
after loading the magic seed into the PRNG and having the PRNG output
the all-zero vector, the buffer stage needs to be updated as well.
This can be achieved by triggering via a clearing operation of the data
output registers.

This resolves lowRISC#22917.

Signed-off-by: Pirmin Vogel <[email protected]>
sameo pushed a commit to sameo/opentitan that referenced this issue Jun 18, 2024
The input masks are now taken from the PRNG buffer stage. This means
after loading the magic seed into the PRNG and having the PRNG output
the all-zero vector, the buffer stage needs to be updated as well.
This can be achieved by triggering via a clearing operation of the data
output registers.

This resolves lowRISC#22917.

Signed-off-by: Pirmin Vogel <[email protected]>
sameo pushed a commit to sameo/opentitan that referenced this issue Jun 18, 2024
The input masks are now taken from the PRNG buffer stage. This means
after loading the magic seed into the PRNG and having the PRNG output
the all-zero vector, the buffer stage needs to be updated as well.
This can be achieved by triggering via a clearing operation of the data
output registers.

This resolves lowRISC#22917.

Signed-off-by: Pirmin Vogel <[email protected]>
sameo pushed a commit to sameo/opentitan that referenced this issue Jun 19, 2024
The input masks are now taken from the PRNG buffer stage. This means
after loading the magic seed into the PRNG and having the PRNG output
the all-zero vector, the buffer stage needs to be updated as well.
This can be achieved by triggering via a clearing operation of the data
output registers.

This resolves lowRISC#22917.

Signed-off-by: Pirmin Vogel <[email protected]>
sameo pushed a commit to sameo/opentitan that referenced this issue Jun 19, 2024
The input masks are now taken from the PRNG buffer stage. This means
after loading the magic seed into the PRNG and having the PRNG output
the all-zero vector, the buffer stage needs to be updated as well.
This can be achieved by triggering via a clearing operation of the data
output registers.

This resolves lowRISC#22917.

Signed-off-by: Pirmin Vogel <[email protected]>
sameo pushed a commit to sameo/opentitan that referenced this issue Jun 27, 2024
The input masks are now taken from the PRNG buffer stage. This means
after loading the magic seed into the PRNG and having the PRNG output
the all-zero vector, the buffer stage needs to be updated as well.
This can be achieved by triggering via a clearing operation of the data
output registers.

This resolves lowRISC#22917.

Signed-off-by: Pirmin Vogel <[email protected]>
andreaskurth pushed a commit that referenced this issue Jun 27, 2024
The input masks are now taken from the PRNG buffer stage. This means
after loading the magic seed into the PRNG and having the PRNG output
the all-zero vector, the buffer stage needs to be updated as well.
This can be achieved by triggering via a clearing operation of the data
output registers.

This resolves #22917.

Signed-off-by: Pirmin Vogel <[email protected]>
AlexJones0 pushed a commit to AlexJones0/opentitan that referenced this issue Jul 8, 2024
The input masks are now taken from the PRNG buffer stage. This means
after loading the magic seed into the PRNG and having the PRNG output
the all-zero vector, the buffer stage needs to be updated as well.
This can be achieved by triggering via a clearing operation of the data
output registers.

This resolves lowRISC#22917.

Signed-off-by: Pirmin Vogel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants