feat: add shopping-cart controller #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raymondfeng
force-pushed
the
cart-controller
branch
from
3513b68 to
4ab818f
Compare
bajtos
approved these changes
Sep 14, 2018
| @param.path.string('userId') userId: string, | ||
| @requestBody({description: 'shopping cart'}) cart: ShoppingCart, | ||
| ) { | ||
| console.log('Shopping cart received', cart); |
There was a problem hiding this comment.
Forgotten console.log statement?
| ) { | ||
| console.log('Shopping cart received', cart); | ||
| if (userId !== cart.userId) { | ||
| throw new HttpErrors['400']( |
There was a problem hiding this comment.
We usually use HttpErrors.BadRequest instead of HttErrors['400'].
Signed-off-by: Raymond Feng <[email protected]>
raymondfeng
force-pushed
the
cart-controller
branch
from
4ab818f to
f68f022
Compare
virkt25
approved these changes
Sep 14, 2018
| @@ -8,18 +8,22 @@ import {Entity, model, property} from '@loopback/repository'; | |||
| /** | |||
| * Item in a shopping cart | |||
| */ | |||
| @model() | |||
There was a problem hiding this comment.
We need to make this a model so this is registered with the openapi spec?
There was a problem hiding this comment.
Yes, that's what leads to loopbackio/loopback-next#1710 too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.