Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Demo scenario: Shopping Cart Component #1481

Closed
4 tasks done
dhmlau opened this issue Jun 26, 2018 · 10 comments
Closed
4 tasks done

Demo scenario: Shopping Cart Component #1481

dhmlau opened this issue Jun 26, 2018 · 10 comments
Assignees
@raymondfeng
Milestone
September Milestone

Comments

@dhmlau
Copy link
Member

dhmlau commented Jun 26, 2018 •
edited
Loading

Description / Steps to reproduce / Feature proposal

As part of the e-commerce store demo scenario in #1476, this task is to create the Shopping Cart component. Shopping cart data will be stored in a distributed in-memory cache, e.g. Redis.

Questions:

  • Are we going to use Redis?
    • Yes
  • Is it going to be another LB app? If so, then I believe it will be blocked by [Epic] KeyValue repository #1447 (KeyValue Repository task)
    • Controller within the same application that uses the KVRepository.

Acceptance Criteria

  • Controller + KV Repository for Redis Database
  • Mockup / Dockerize a Redis Instance for use with this
  • Simple Model: Cart (id) containing multiple Products (ids + quantity)
  • A REST API controller either full CRUD or at least the APIs that make sense for this component
@dhmlau dhmlau added p1 labels Jun 26, 2018
@dhmlau dhmlau mentioned this issue Jun 26, 2018
Closed
@bajtos bajtos added p2 and removed p1 labels Jul 30, 2018
@bajtos
Copy link
Member

bajtos commented Jul 30, 2018

Yes, this is blocked by #1447, I am relabelling this story as p2.

@bajtos bajtos mentioned this issue Jul 30, 2018
Closed
12 tasks
@raymondfeng raymondfeng mentioned this issue Aug 28, 2018
Merged
@bajtos
Copy link
Member

bajtos commented Aug 28, 2018

In progress by @raymondfeng - see loopbackio/loopback4-example-shopping#4

@bajtos bajtos mentioned this issue Aug 28, 2018
Closed
20 tasks
@bajtos bajtos added this to the September Milestone milestone Aug 30, 2018
@bajtos
Copy link
Member

bajtos commented Aug 30, 2018

The acceptance criteria don't not describe any Controller (REST API), is that intentional?

IMO, a shopping cart component is not complete without a REST API to access the data.

@virkt25
Copy link
Contributor

virkt25 commented Aug 31, 2018 •
edited
Loading

Controller + KV Repository for Redis Database

When I wrote the acceptance criteria it was with the intention that there will be a full CRUD controller for this component. -- This is also meant to be reflected in the estimate this task was given of an 8.

My apologies for not being more specific -- but a full CRUD controller (or at least the APIs that make sense for this Model / Controller).

@bajtos
Copy link
Member

bajtos commented Aug 31, 2018

No worries. I am going to edit the issue description and add a CRUD controller to the list of acceptance criteria.

@bajtos bajtos mentioned this issue Sep 4, 2018
Closed
6 tasks
@raymondfeng raymondfeng mentioned this issue Sep 14, 2018
Merged
@virkt25
Copy link
Contributor

virkt25 commented Sep 19, 2018

@raymondfeng Is this good to close?

@raymondfeng
Copy link
Contributor

@virkt25 Please review loopbackio/loopback4-example-shopping#13 1st.

@raymondfeng
Copy link
Contributor

One last piece: loopbackio/loopback4-example-shopping#14

@jannyHou
Copy link
Contributor

Hi @raymondfeng are we ok to close the issue since 2 PRs above are merged?

@dhmlau
Copy link
Member Author

dhmlau commented Sep 25, 2018

Closing as resolved.

@dhmlau dhmlau closed this as completed Sep 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@raymondfeng raymondfeng

Labels
None yet
Projects
None yet
Milestone
September Milestone
Development

No branches or pull requests
7 participants
@raymondfeng @bajtos @virkt25 @jannyHou @b-admike @shimks @dhmlau