Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix performing actions from the city screen #862

Merged
merged 2 commits into from
Feb 5, 2022

Conversation

lmoureaux
Copy link
Contributor

The condition in most if(can_issue_orders()) was reversed.
Closes #819.


Remains to be seen if I'm the only one not getting the context menu at all. If not, I'll also add the fix to this PR.

The condition in most if(can_issue_orders()) was reversed.
Closes longturn#819.
@lmoureaux lmoureaux requested a review from jwrober January 31, 2022 23:46
On my system, the event filter was not receiving the context menu event. Drop
it altogether and connect customContextMenuRequested to a lambda that includes
the previously used code.
@lmoureaux
Copy link
Contributor Author

Remains to be seen if I'm the only one not getting the context menu at all. If not, I'll also add the fix to this PR.

Added anyway.

@jwrober
Copy link
Collaborator

jwrober commented Feb 4, 2022

I went into a city with 3 units - Stealth Bomber, Howitzer and a AWACS. I right clicked on the Howitzer and picked set home city and then the units bar at the bottom disappeared and was replaced with the unit selection bar and I have to close the city dialog and come back in to see the units bar again.
image

@jwrober
Copy link
Collaborator

jwrober commented Feb 4, 2022

Same is true if I do Sentry Unit command. Activate unit does what I expect it to by closing the city dialog. If I do Disband unit, the unit bar stays there, but all the units go into a kind of greyed out state and are not clickable.

@lmoureaux
Copy link
Contributor Author

I went into a city with 3 units - Stealth Bomber, Howitzer and a AWACS. I right clicked on the Howitzer and picked set home city and then the units bar at the bottom disappeared and was replaced with the unit selection bar and I have to close the city dialog and come back in to see the units bar again.

Another instance of #611

@jwrober
Copy link
Collaborator

jwrober commented Feb 4, 2022

Another instance of #611

Ok in that case, I can indeed disband units inside cities with a right-click.

@lmoureaux lmoureaux merged commit 6ae7a03 into longturn:master Feb 5, 2022
@lmoureaux lmoureaux deleted the bugfix/disband-in-city branch February 5, 2022 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disbanding units via right click in city isn't working
2 participants