Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Present units" clashes with unit orders when investigating cities #611

Closed
lmoureaux opened this issue Aug 31, 2021 · 5 comments
Closed

"Present units" clashes with unit orders when investigating cities #611

lmoureaux opened this issue Aug 31, 2021 · 5 comments
Labels
bug Something isn't working gui This issue requires changes to the user interface
Milestone
v3.1-stable

Comments

@lmoureaux
Copy link
Contributor

Describe the bug

The "Present units" panel overlaps with the unit description and orders panel when investigating a city.

To Reproduce
Steps to reproduce the behavior:

  1. Investigate a city

Expected behavior

There is no overlap.

Platform and version (please complete the following information):

  • OS: some Linux
  • Freeciv21 version: 3.0-alpha4
  • Ruleset/Longturn game (if applicable): LTEx24

Additional context

Reported by soundnfury on Discord.
@lmoureaux lmoureaux added bug Something isn't working Untriaged This issue or PR needs triaging labels Aug 31, 2021
@lmoureaux lmoureaux removed the Untriaged This issue or PR needs triaging label Oct 15, 2021
@lmoureaux
Copy link
Contributor Author

Confirmed. This is a quite annoying bug.

@jwrober jwrober added the gui This issue requires changes to the user interface label Nov 7, 2021
@jwrober jwrober added this to the v3.0-beta.1 milestone Nov 7, 2021
@lmoureaux lmoureaux mentioned this issue Feb 4, 2022
Merged
@lmoureaux
Copy link
Contributor Author

Also related are various instances where managing units from the city screen result in the same overlap problem.

@lmoureaux
Copy link
Contributor Author

Pushing to beta2 because more refactoring is expected there.

@lmoureaux lmoureaux modified the milestones: v3.0-beta.1, v3.0-beta.2 Mar 1, 2022
@lmoureaux lmoureaux modified the milestones: v3.0-beta.2, v3.0-beta.3 Jul 8, 2022
@lmoureaux lmoureaux mentioned this issue Aug 13, 2022
Open
@lmoureaux lmoureaux mentioned this issue Dec 11, 2022
Open
@lmoureaux lmoureaux modified the milestones: v3.0-stable, v3.1-stable Dec 11, 2022
@lmoureaux
Copy link
Contributor Author

Got better with #2060, now the city screen can be closed, the unit moved, and the city screen reopened (provided no RTS).

@lmoureaux
Copy link
Contributor Author

Cannot reproduce in current master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working gui This issue requires changes to the user interface
Projects
None yet
Milestone
v3.1-stable
Development

No branches or pull requests
2 participants
@lmoureaux @jwrober