Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give names to units #410

Merged
merged 7 commits into from
Apr 6, 2021
Merged

Conversation

lmoureaux
Copy link
Contributor

This would be useful eg in a WWII scenario with Pearl Harbour ships called by their historical names. Changes the network protocol. Requested by @jwrober.

Closes #281.

The name is empty by default, but can be set by sending unit_rename packets. It
is limited to MAX_LEN_NAME which is 48 bytes including the terminating zero.

Requested by jwrober in longturn#281.
* In the middle click popup
* In the unit orders panel

See longturn#281.
This makes the change instantaneous, it required a reconnect before.

See longturn#281.
@lmoureaux lmoureaux merged commit 933d3d2 into longturn:master Apr 6, 2021
@lmoureaux lmoureaux deleted the feature/named-units branch April 6, 2021 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow the naming of units
1 participant