Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow the naming of units #281

Closed
jwrober opened this issue Feb 18, 2021 · 1 comment · Fixed by #410
Closed

Allow the naming of units #281

jwrober opened this issue Feb 18, 2021 · 1 comment · Fixed by #410
Assignees
@lmoureaux
Labels
enhancement New feature or request

Comments

@jwrober
Copy link
Collaborator

jwrober commented Feb 18, 2021

We name cities, why not units, especially Naval vessels.
@lmoureaux lmoureaux added the enhancement New feature or request label Feb 18, 2021
@lmoureaux
Copy link
Contributor

Just checked, this will require a protocol change/extension.

lmoureaux added a commit to lmoureaux/freeciv21 that referenced this issue Apr 6, 2021
@lmoureaux
Give names to units
7e9fd01 
The name is empty by default, but can be set by sending unit_rename packets. It
is limited to MAX_LEN_NAME which is 48 bytes including the terminating zero.

Requested by jwrober in longturn#281.
lmoureaux added a commit to lmoureaux/freeciv21 that referenced this issue Apr 6, 2021
@lmoureaux
Save unit names
bfb0e96 
See longturn#281.
lmoureaux added a commit to lmoureaux/freeciv21 that referenced this issue Apr 6, 2021
@lmoureaux
Add a UI to change unit names
60ad9d7 
See longturn#281.
lmoureaux added a commit to lmoureaux/freeciv21 that referenced this issue Apr 6, 2021
@lmoureaux
Show unit names in the UI
4b8df2c 
* In the middle click popup
* In the unit orders panel

See longturn#281.
lmoureaux added a commit to lmoureaux/freeciv21 that referenced this issue Apr 6, 2021
@lmoureaux
Send updated unit when it is renamed
d2e8193 
See longturn#281.
lmoureaux added a commit to lmoureaux/freeciv21 that referenced this issue Apr 6, 2021
@lmoureaux
Update units on the client when their name changes
3ce1b2d 
This makes the change instantaneous, it required a reconnect before.

See longturn#281.
@lmoureaux lmoureaux self-assigned this Apr 6, 2021
@lmoureaux lmoureaux mentioned this issue Apr 6, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lmoureaux lmoureaux

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Give names to units lmoureaux/freeciv21
2 participants
@lmoureaux @jwrober