Do not rebuild contents when UWT table is updated #2305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A timer triggers a periodic update of the UWT table in the unit view. Each update clears the current contents of the table and rebuilds it from scratch. As a result, the list loses its scrolling state and scrolls back up. This commit changes the behavior to update existing entries and only selectively delete and add entries as needed. To match units to their entries in the table, a hidden id column has been added to the UWT table.
|
Interesting approach. I'll give it a test. |
|
Re-reading my diff, I noticed that I named the new variables using camelCase (the style we are using at my day job), this doesn't follow the style used in the existing code. I will push an update later today to change these to snake_case, but this will be a purely cosmetic change. |
No functional changes.
|
Tested #2305. UWT table scrolls nicely without rushing back up.
|
jwrober
approved these changes
Jun 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A timer triggers a periodic update of the UWT table in the unit view. Each update clears the current contents of the table and rebuilds it from scratch. As a result, the list loses its scrolling state and scrolls back up.
This PR changes the behavior to update existing entries and only selectively delete and add entries as needed.
To match units to their entries in the table, a hidden id column has been added to the UWT table.
Closes #2296