Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UWT table on Units view doesn't allow you to scroll down #2296

Closed
jwrober opened this issue May 25, 2024 · 1 comment · Fixed by #2305
Closed

UWT table on Units view doesn't allow you to scroll down #2296

jwrober opened this issue May 25, 2024 · 1 comment · Fixed by #2305
Assignees
Labels
bug Something isn't working gui This issue requires changes to the user interface
Milestone

Comments

@jwrober
Copy link
Collaborator

jwrober commented May 25, 2024

Describe the bug
If you have units waiting for UWT to expire and the list is bigger than the page, then you get a vertical scroll bar. If you try to scroll down, you can't. The game always drops you back to the top.

To Reproduce
Steps to reproduce the behavior:

  1. Open a game with lots of units with UWT
  2. Click on Units View
  3. Try to scroll down to see the bottom one
  4. See error

Expected behavior
Scroll bars work as expected.

Screenshots
If applicable, add screenshots to help explain your problem.

Platform and version (please complete the following information):

  • OS: Linux
  • Freeciv21 version: 3.1-beta.1
  • Ruleset/Longturn game (if applicable):

Additional context
Came up as part of a conversation with @hugomflavio

@jwrober jwrober added bug Something isn't working gui This issue requires changes to the user interface labels May 25, 2024
@jwrober jwrober added this to the v3.1-stable milestone May 25, 2024
@jwrober jwrober self-assigned this May 25, 2024
@jwrober
Copy link
Collaborator Author

jwrober commented May 25, 2024

Offending code starts here

QTimer *timer = new QTimer(this);

The QTimer updates every second and then repaints/updates the table. The purpose is to update the countdown timer in the table, but seems to have a deleterious effect with long lists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working gui This issue requires changes to the user interface
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants