Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a map gen manual page #2196

Merged
merged 1 commit into from
Feb 9, 2024
Merged

Add a map gen manual page #2196

merged 1 commit into from
Feb 9, 2024

Conversation

jwrober
Copy link
Collaborator

@jwrober jwrober commented Feb 9, 2024

Closes #2129

@jwrober jwrober requested review from blabber and lmoureaux February 9, 2024 01:38
blabber
blabber reviewed Feb 9, 2024
View reviewed changes
Copy link
Collaborator

@blabber blabber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take a look at my comment regarding the spelling of Pangea vs Pangaea. Apart from that this looks good to me (and although I don't see myself creating maps in the near future, it was an interesting read).

docs/Manuals/Advanced/map-generator.rst Show resolved Hide resolved
@jwrober jwrober merged commit 996eb8f into longturn:master Feb 9, 2024
20 checks passed
@jwrober jwrober deleted the docs/map-recipes branch March 30, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blabber blabber blabber approved these changes

@lmoureaux lmoureaux Awaiting requested review from lmoureaux

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Map Generator Recipes
2 participants
@jwrober @blabber