Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for stable releases #1286

Merged
merged 3 commits into from
Aug 18, 2022

Conversation

jwrober
Copy link
Collaborator

@jwrober jwrober commented Aug 15, 2022

Closes #1252

@jwrober jwrober requested a review from lmoureaux August 16, 2022 22:33
Copy link
Contributor

@lmoureaux lmoureaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get the following in build/utility/fc_version.h:

#ifndef VERSION_STRING
#define VERSION_STRING "3.0.0.0-Stable"
#endif

This should be just 3.0.

@jwrober
Copy link
Collaborator Author

jwrober commented Aug 17, 2022

That is not possible. The build fails if not all 5 variables are populated with something. When we only tag to a major and minor version, I set static values to populate something in the variables to get the build to complete.

If there is a way to get around this limitation in the code somewhere, I could attempt to change it or you could push it to my branch to include here.

While we keep the patch and emergency versions defined, we don't include them
in the version string because they're always 0.
@lmoureaux
Copy link
Contributor

If there is a way to get around this limitation in the code somewhere, I could attempt to change it or you could push it to my branch to include here.

Branch updated, please review my changes 😅

I couldn't find any use of the fc_version script, so the file was useless.
@jwrober
Copy link
Collaborator Author

jwrober commented Aug 17, 2022

Branch updated, please review my changes

You broke it, lol. Need to update CMakeLists.txt is the root.

@lmoureaux lmoureaux force-pushed the feature/autorev-update branch from b3689ab to 5e2e0b5 Compare August 17, 2022 22:09
@lmoureaux
Copy link
Contributor

You broke it, lol. Need to update CMakeLists.txt is the root.

Done

@jwrober
Copy link
Collaborator Author

jwrober commented Aug 18, 2022

I ran a subsequent test of all of the PR via the eval_pr script. I tagged my local with a stable tag and was able to build the whole thing and get the string @lmoureaux wanted. I think we can merge this, just need to remove the "changes requested" on the review.

@lmoureaux lmoureaux self-requested a review August 18, 2022 22:40
@lmoureaux lmoureaux merged commit 2d1a2c6 into longturn:master Aug 18, 2022
@jwrober jwrober deleted the feature/autorev-update branch August 23, 2022 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AutoRevision needs to support stable releases
2 participants