-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for stable releases #1286
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I get the following in build/utility/fc_version.h
:
#ifndef VERSION_STRING
#define VERSION_STRING "3.0.0.0-Stable"
#endif
This should be just 3.0
.
That is not possible. The build fails if not all 5 variables are populated with something. When we only tag to a major and minor version, I set static values to populate something in the variables to get the build to complete. If there is a way to get around this limitation in the code somewhere, I could attempt to change it or you could push it to my branch to include here. |
While we keep the patch and emergency versions defined, we don't include them in the version string because they're always 0.
Branch updated, please review my changes 😅 |
I couldn't find any use of the fc_version script, so the file was useless.
You broke it, lol. Need to update CMakeLists.txt is the root. |
b3689ab
to
5e2e0b5
Compare
Done |
I ran a subsequent test of all of the PR via the eval_pr script. I tagged my local with a stable tag and was able to build the whole thing and get the string @lmoureaux wanted. I think we can merge this, just need to remove the "changes requested" on the review. |
Closes #1252