Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AutoRevision needs to support stable releases #1252

Closed
jwrober opened this issue Aug 12, 2022 · 1 comment · Fixed by #1286
Closed

AutoRevision needs to support stable releases #1252

jwrober opened this issue Aug 12, 2022 · 1 comment · Fixed by #1286
Assignees
Labels
enhancement New feature or request spec-file Related to Rulesets, Tilesets, Musicsets, Soundsets, etc. tools Issues related to mp, ruledit, etc along with CI and build tools.
Milestone

Comments

@jwrober
Copy link
Collaborator

jwrober commented Aug 12, 2022

Is your feature request related to a problem? Please describe.
When we tag a release, a process call AutoRevision runs to update the Freeciv21 code with the tagged version automatically. Right now we have been tagging unstable Alpha and Beta releases and are close to having a stable release.

Describe the solution you'd like
The general rule of a stable release is the tag does not have a dash (-) in with a patch release text provided. Today our releases are like this: v3.0-beta.3 and AutoRevision parses that out a v3.0.base10(git hash)-beta.3. We need AutoRev to recognize that if the tag string ends at .0 and does not have a dash (-) with subsequent text that this is a stable release. When that is detected then AutoRevision only gives us a version of vX.0 with not base10(git hash) or anything else.

Describe alternatives you've considered
It was discussed to potentially leave the base10(git hash) as part of any version, however the developers decided for stable releases we don't want that there, only for unstable point releases.

Additional context
We are near a full v3.0!

@jwrober jwrober added enhancement New feature or request spec-file Related to Rulesets, Tilesets, Musicsets, Soundsets, etc. tools Issues related to mp, ruledit, etc along with CI and build tools. labels Aug 12, 2022
@jwrober jwrober added this to the v3.0-beta.4 milestone Aug 12, 2022
@lmoureaux
Copy link
Contributor

We need AutoRev to recognize that if the tag string ends at .0 and does not have a dash (-) with subsequent text that this is a stable release.

I don't think the .0 part is a necessary condition, because we'll have v3.1 one day

@jwrober jwrober self-assigned this Aug 15, 2022
jwrober added a commit to jwrober/freeciv21 that referenced this issue Aug 15, 2022
lmoureaux pushed a commit that referenced this issue Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request spec-file Related to Rulesets, Tilesets, Musicsets, Soundsets, etc. tools Issues related to mp, ruledit, etc along with CI and build tools.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants