-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs - Client Manual #1211
Docs - Client Manual #1211
Conversation
Includes a new screenshot for distribution files
@lmoureaux , @pranavtifr , @daavko, maybe break this up into pieces. LM takes the first 9 commits, PR takes the next 8 and D takes the last 8? |
Here is a link to the generated content all in one -- https://longturn--1211.org.readthedocs.build/en/1211/General/Manuals/client-manual.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Went through "my" commits once and noted down remarks going from typos to metaphysical thoughts.
We may need to establish capitalization rules, because I don't think it's fully consistent within this PR, with the client, and within the documentation.
Aside from my full review (which is in progress), we probably need concrete rules on usage of the Oxford comma. It's sometimes used, sometimes not. It'd be nice to be consistent. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Part 1/8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Part 2/8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Part 3/8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Part 4/8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Part 5/8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Part 5/8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Part 7/8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Part 8/8
Good point. I've take a note to update in a future PR. |
I'd like to take a second look before this is merged, there's a lot to digest 😅 |
Brand new Client Manual for RTD. Closes #1058