Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it easier to know/see that a diplomatic screen is open #843

Closed
jwrober opened this issue Jan 23, 2022 · 8 comments
Closed

Make it easier to know/see that a diplomatic screen is open #843

jwrober opened this issue Jan 23, 2022 · 8 comments
Labels
enhancement New feature or request gui This issue requires changes to the user interface

Comments

@jwrober
Copy link
Collaborator

jwrober commented Jan 23, 2022

Is your feature request related to a problem? Please describe.
Right now you have to right-click on the Nations tab to open up an existing diplomatic screen. If you effectively have to "know" that its there. The client does not prompt.

Describe the solution you'd like
Add a button or something to the nations tab to open the diplomatic screen. Maybe make it blink or something to draw your eye to it to know that something is there requiring your attention.

Describe alternatives you've considered
Its been discussed that we need a client manual of some kind, but RTFM should not be a solution here.

Additional context
Trying to reduce the number of hidden features to make the client more intuitive.

@jwrober jwrober added enhancement New feature or request Untriaged This issue or PR needs triaging labels Jan 23, 2022
@lmoureaux lmoureaux added gui This issue requires changes to the user interface and removed Untriaged This issue or PR needs triaging labels Jan 23, 2022
@lmoureaux
Copy link
Contributor

lmoureaux commented Jan 23, 2022

How would it interact with the top bar we've been discussing in #750 ?

@jwrober
Copy link
Collaborator Author

jwrober commented Jan 23, 2022

My initial thought is the new top bar would also have an icon or something to draw your eye to.

@jwrober jwrober added this to the v3.0-beta.2 milestone Jan 23, 2022
@jwrober jwrober removed this from the v3.0-beta.2 milestone Apr 6, 2022
@jwrober
Copy link
Collaborator Author

jwrober commented Aug 19, 2022

This was documented in PR #1211 and with implementation of the top bar, it is much easier to see if a diplomatic screen is open. Closing

@jwrober jwrober closed this as completed Aug 19, 2022
@lmoureaux
Copy link
Contributor

I don't understand how it's easier now ❓

@jwrober
Copy link
Collaborator Author

jwrober commented Aug 19, 2022

I don't understand how it's easier now question

Because the button changes from saying "Nations" to saying "<Nation Name"> with the flag of the nation that has an open diplomatic screen. I think that is pretty obvious.

@lmoureaux
Copy link
Contributor

Hmmm... I think that was already the case but it was reset easily

@jwrober
Copy link
Collaborator Author

jwrober commented Aug 19, 2022

I think your implementation of the top bar makes it work great now. I opened this issue before the top bar was done.

@lmoureaux
Copy link
Contributor

ok 👐

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request gui This issue requires changes to the user interface
Projects
None yet
Development

No branches or pull requests

2 participants