Improve the layout of the "load game" page #1166
Conversation
|
So with the default NightStalker theme, the dialog overlaps the LongTurn logo as shown above and here.
Looks unprofessional. I would suggest increasing the size the the dialog so the image shows uncovered in the lower right corner. Since the other shipped themes don't have an image there it should be fine. Also if you open the dialog, click cancel and then load it again you will briefly see the new game dialog and then it is replaced by the load game dialog. Lastly, if you open the dialog, pick a saved game to show the preview, click cancel and then load saved game again, the preview of the game you clicked on the first try still shows, but the save game file in the table is not selected. I think it should be clean every time. |
I don't think this one is new. |
I can recreate in beta.3, so yea not new. But if can be fixed here while the code is being worked on would be good. |
Looks like a timing-dependent issue, it doesn't happen very often for me. |
The column with game information in the page_load dialog (to the right of the window) was still jumping around depending on the size of the map. There were also concerns that the Longturn logo shown at the bottom right with the Nightstalker theme was hidden (which still happens when the window is small, but fixing that is a bigger change). The column size is hacked in by having the right column expand to 25% of the window width. See longturn#1166.
When loading the preview fails because we couldn't extract the preview from the save, be conservative and disable the "Load" button (how could the server load the file if we can't?). Also hide the preview from the previously selected item, if any. See longturn#1166.
|
Should have addressed most concerns. The LT logo will still be partially covered at small window sizes, but now it should at least be fine when the window is big enough. |
|
OS X CI: https://gitlab.freedesktop.org/ is down |
Less jumping around = better UX.
This way the buttons are in the correct (platform-dependent) location and get assigned the right icon automatically.
The user doesn't need to know the time zone. It uses their current local time anyway.
The column with game information in the page_load dialog (to the right of the window) was still jumping around depending on the size of the map. There were also concerns that the Longturn logo shown at the bottom right with the Nightstalker theme was hidden (which still happens when the window is small, but fixing that is a bigger change). The column size is hacked in by having the right column expand to 25% of the window width. See longturn#1166.
Select the latest save when we switch to page_load. This way, to continue the latest game one can just click on "Load".
When loading the preview fails because we couldn't extract the preview from the save, be conservative and disable the "Load" button (how could the server load the file if we can't?). Also hide the preview from the previously selected item, if any. See longturn#1166.
The column with game information in the page_load dialog (to the right of the window) was still jumping around depending on the size of the map. There were also concerns that the Longturn logo shown at the bottom right with the Nightstalker theme was hidden (which still happens when the window is small, but fixing that is a bigger change). The column size is hacked in by having the right column expand to 25% of the window width. See #1166.
This PR changes the layout of the "load game" screen to jump around less. There are still huge improvements to be made but I think it's a good start.
The new layout looks like this:
After #1165.
Related to #115.