Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of fileinfo and fileinfo_list #1165

Merged
merged 1 commit into from
Aug 2, 2022

Conversation

lmoureaux
Copy link
Contributor

Use QFileInfo and QFileInfoList instead. While we're at it, simplify the API a
little.

@lmoureaux lmoureaux added the refactoring This issue requires code refactoring label Jul 30, 2022
@lmoureaux lmoureaux requested a review from psampathkumar July 30, 2022 16:13
@lmoureaux
Copy link
Contributor Author

The CI needs #1164

Use QFileInfo and QFileInfoList instead. While we're at it, simplify the API a
little.
@lmoureaux lmoureaux force-pushed the refactor/fileinfo branch from 9954b06 to d901f7a Compare July 30, 2022 16:37
Copy link
Contributor

@psampathkumar psampathkumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loading a save seems to work just fine.

@psampathkumar psampathkumar merged commit 188c1f4 into longturn:master Aug 2, 2022
@psampathkumar psampathkumar deleted the refactor/fileinfo branch August 2, 2022 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring This issue requires code refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants