Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The city dialog should display how many citizens can be made content with existing buildings #269

Closed
lmoureaux opened this issue Feb 15, 2021 · 1 comment · Fixed by #1214
Closed

The city dialog should display how many citizens can be made content with existing buildings #269

lmoureaux opened this issue Feb 15, 2021 · 1 comment · Fixed by #1214
Labels
enhancement New feature or request gui This issue requires changes to the user interface server This issue requires changes to the server
Milestone
v3.0-stable

Comments

@lmoureaux
Copy link
Contributor

Currently, the citizens made content by buildings are shown, but one can't see how much the city can grow before the first unhappy citizen appears. This makes celebration harder.

Initial proposal is to add it to the relevant tooltip in the Happiness tab. In the long run some more graphical depiction could be added.
@lmoureaux lmoureaux added the enhancement New feature or request label Feb 15, 2021
@psampathkumar
Copy link
Contributor

Lol. I just saw this. Anyways, relevant thing I did with the city-report tab

psampathkumar/freeciv@ea17ba0

@mir3x mir3x mentioned this issue Apr 13, 2021
Closed
@jwrober jwrober added gui This issue requires changes to the user interface server This issue requires changes to the server labels Jan 23, 2022
@jwrober jwrober added this to the v3.0-beta.2 milestone Jan 25, 2022
@lmoureaux lmoureaux modified the milestones: v3.0-beta.2, v3.0-beta.3 Jul 8, 2022
lmoureaux added a commit to lmoureaux/freeciv21 that referenced this issue Aug 7, 2022
@lmoureaux
Expand the text for empire size unhappiness
8ae4127 
Improve the city dialog tooltip text that explains how many citizens are
unhappy because of the number of cities. Write two paragraphs: the first
describing the rules for the current player, and the second the status of the
city at hand. The total number of citizens that can be made content without
improvements is also shown; see longturn#269.
@lmoureaux lmoureaux mentioned this issue Aug 7, 2022
Merged
lmoureaux added a commit to lmoureaux/freeciv21 that referenced this issue Aug 7, 2022
@lmoureaux
Expand the text for empire size unhappiness
2fc9039 
Improve the city dialog tooltip text that explains how many citizens are
unhappy because of the number of cities. Write two paragraphs: the first
describing the rules for the current player, and the second the status of the
city at hand. The total number of citizens that can be made content without
improvements is also shown; see longturn#269.
lmoureaux added a commit to lmoureaux/freeciv21 that referenced this issue Aug 7, 2022
@lmoureaux
Expand the text for empire size unhappiness
9370a32 
Improve the city dialog tooltip text that explains how many citizens are
unhappy because of the number of cities. Write two paragraphs: the first
describing the rules for the current player, and the second the status of the
city at hand. The total number of citizens that can be made content without
improvements is also shown; see longturn#269.
lmoureaux added a commit to lmoureaux/freeciv21 that referenced this issue Aug 7, 2022
@lmoureaux
Expand the city dialog text for luxury spendings
390a13f 
Improve the city dialog tooltip text that explains how many citizens are
made happier by luxury. This provides a lot more information than the previous
"Luxury: %d total", which will hopefully help towards longturn#269.
@lmoureaux lmoureaux mentioned this issue Aug 7, 2022
Merged
lmoureaux added a commit to lmoureaux/freeciv21 that referenced this issue Aug 7, 2022
@lmoureaux
Expand the city dialog text for building happiness (Make_Content)
284fbcd 
Give the total number of citizens that can be made content and details about
active effects. This should help towards longturn#269.
@lmoureaux lmoureaux mentioned this issue Aug 7, 2022
Merged
lmoureaux added a commit to lmoureaux/freeciv21 that referenced this issue Aug 7, 2022
@lmoureaux
Expand the city dialog text for luxury spendings
9935841 
Improve the city dialog tooltip text that explains how many citizens are
made happier by luxury. This provides a lot more information than the previous
"Luxury: %d total", which will hopefully help towards longturn#269.
lmoureaux added a commit to lmoureaux/freeciv21 that referenced this issue Aug 7, 2022
@lmoureaux
Expand the city dialog text for building happiness (Make_Content)
d115cfc 
Give the total number of citizens that can be made content and details about
active effects. This should help towards longturn#269.
lmoureaux added a commit to lmoureaux/freeciv21 that referenced this issue Aug 7, 2022
@lmoureaux
Expand the city dialog text for nationality
4a7d49c 
Explain the rules and give the result of the calculation. The rule sentence is
not fully correct but it's easier to understand than the actual mechanism.
Hopefully helps with longturn#269.
lmoureaux added a commit to lmoureaux/freeciv21 that referenced this issue Aug 7, 2022
@lmoureaux
Expand the city dialog text for nationality
7055e35 
Explain the rules and give the result of the calculation. The rule sentence is
not fully correct but it's easier to understand than the actual mechanism.
Hopefully helps with longturn#269.
@lmoureaux lmoureaux mentioned this issue Aug 7, 2022
Merged
lmoureaux added a commit to lmoureaux/freeciv21 that referenced this issue Aug 7, 2022
@lmoureaux
Expand the city dialog text for luxury spendings
d52938c 
Improve the city dialog tooltip text that explains how many citizens are
made happier by luxury. This provides a lot more information than the previous
"Luxury: %d total", which will hopefully help towards longturn#269.
lmoureaux added a commit that referenced this issue Aug 7, 2022
@lmoureaux
Expand the text for empire size unhappiness
021a47e 
Improve the city dialog tooltip text that explains how many citizens are
unhappy because of the number of cities. Write two paragraphs: the first
describing the rules for the current player, and the second the status of the
city at hand. The total number of citizens that can be made content without
improvements is also shown; see #269.
lmoureaux added a commit to lmoureaux/freeciv21 that referenced this issue Aug 7, 2022
@lmoureaux
Expand the city dialog text for luxury spendings
48d1a5a 
Improve the city dialog tooltip text that explains how many citizens are
made happier by luxury. This provides a lot more information than the previous
"Luxury: %d total", which will hopefully help towards longturn#269.
lmoureaux added a commit to lmoureaux/freeciv21 that referenced this issue Aug 7, 2022
@lmoureaux
Expand the city dialog text for luxury spendings
a1f7b0f 
Improve the city dialog tooltip text that explains how many citizens are
made happier by luxury. This provides a lot more information than the previous
"Luxury: %d total", which will hopefully help towards longturn#269.
lmoureaux added a commit to lmoureaux/freeciv21 that referenced this issue Aug 7, 2022
@lmoureaux
Expand the city dialog text for building happiness (Make_Content)
8d250b4 
Give the total number of citizens that can be made content and details about
active effects. This should help towards longturn#269.
lmoureaux added a commit to lmoureaux/freeciv21 that referenced this issue Aug 7, 2022
@lmoureaux
Expand the city dialog text for nationality
3b9a79c 
Explain the rules and give the result of the calculation. The rule sentence is
not fully correct but it's easier to understand than the actual mechanism.
Hopefully helps with longturn#269.
lmoureaux added a commit to lmoureaux/freeciv21 that referenced this issue Aug 7, 2022
@lmoureaux
Expand the city dialog text for military happiness
6da4b0c 
Improve the description of martial law by listing the number of units applying
it and the total number of citizens made happier as a result.
Greatly expand the description of military unhappiness by explaining the three
effects that come into play and providing numbers similiar to the above.

Should help with longturn#269.
lmoureaux added a commit to lmoureaux/freeciv21 that referenced this issue Aug 7, 2022
@lmoureaux
Expand the city dialog text for military happiness
9ec8341 
Improve the description of martial law by listing the number of units applying
it and the total number of citizens made happier as a result.
Greatly expand the description of military unhappiness by explaining the three
effects that come into play and providing numbers similiar to the above.

Should help with longturn#269.
@lmoureaux lmoureaux mentioned this issue Aug 7, 2022
Merged
lmoureaux added a commit that referenced this issue Aug 7, 2022
@lmoureaux
Expand the city dialog text for luxury spendings
cfb6139 
Improve the city dialog tooltip text that explains how many citizens are
made happier by luxury. This provides a lot more information than the previous
"Luxury: %d total", which will hopefully help towards #269.
lmoureaux added a commit to lmoureaux/freeciv21 that referenced this issue Aug 8, 2022
@lmoureaux
Expand the city dialog text for wonders
3da57a3 
Improve the description by explaining which effects are active and, for two of
them, what contributes to their value (the third one is a simple binary effect,
and that's harder to display properly). Helps longturn#269.

Factor out a function to build such effect descriptions so we don't need to
repeat the same code over and over again.
@lmoureaux lmoureaux mentioned this issue Aug 8, 2022
Merged
lmoureaux added a commit to lmoureaux/freeciv21 that referenced this issue Aug 8, 2022
@lmoureaux
Expand the city dialog text for building happiness (Make_Content)
44fe3cb 
Give the total number of citizens that can be made content and details about
active effects. This should help towards longturn#269.
lmoureaux added a commit to lmoureaux/freeciv21 that referenced this issue Aug 8, 2022
@lmoureaux
Expand the city dialog text for military happiness
8fc7d6e 
Improve the description of martial law by listing the number of units applying
it and the total number of citizens made happier as a result.
Greatly expand the description of military unhappiness by explaining the three
effects that come into play and providing numbers similiar to the above.

Should help with longturn#269.
lmoureaux added a commit to lmoureaux/freeciv21 that referenced this issue Aug 8, 2022
@lmoureaux
Expand the city dialog text for wonders
dbbc77a 
Improve the description by explaining which effects are active and, for two of
them, what contributes to their value (the third one is a simple binary effect,
and that's harder to display properly). Helps longturn#269.

Factor out a function to build such effect descriptions so we don't need to
repeat the same code over and over again.
lmoureaux added a commit to lmoureaux/freeciv21 that referenced this issue Aug 8, 2022
@lmoureaux
Expand the city dialog text for wonders
5542476 
Improve the description by explaining which effects are active and, for two of
them, what contributes to their value (the third one is a simple binary effect,
and that's harder to display properly). Helps longturn#269.

Factor out a function to build such effect descriptions so we don't need to
repeat the same code over and over again.
jwrober pushed a commit that referenced this issue Aug 8, 2022
@lmoureaux @jwrober
Expand the city dialog text for building happiness (Make_Content)
95d9470 
Give the total number of citizens that can be made content and details about
active effects. This should help towards #269.
lmoureaux added a commit to lmoureaux/freeciv21 that referenced this issue Aug 8, 2022
@lmoureaux
Expand the city dialog text for nationality
5eb1f29 
Explain the rules and give the result of the calculation. The rule sentence is
not fully correct but it's easier to understand than the actual mechanism.
Hopefully helps with longturn#269.
lmoureaux added a commit to lmoureaux/freeciv21 that referenced this issue Aug 8, 2022
@lmoureaux
Expand the city dialog text for nationality
037847e 
Explain the rules and give the result of the calculation. The rule sentence is
not fully correct but it's easier to understand than the actual mechanism.
Hopefully helps with longturn#269.
lmoureaux added a commit that referenced this issue Aug 8, 2022
@lmoureaux
Expand the city dialog text for nationality
a5e26fc 
Explain the rules and give the result of the calculation. The rule sentence is
not fully correct but it's easier to understand than the actual mechanism.
Hopefully helps with #269.
lmoureaux added a commit to lmoureaux/freeciv21 that referenced this issue Aug 8, 2022
@lmoureaux
Expand the city dialog text for military happiness
b7dab14 
Improve the description of martial law by listing the number of units applying
it and the total number of citizens made happier as a result.
Greatly expand the description of military unhappiness by explaining the three
effects that come into play and providing numbers similiar to the above.

Should help with longturn#269.
jwrober pushed a commit that referenced this issue Aug 9, 2022
@lmoureaux @jwrober
Expand the city dialog text for military happiness
7990601 
Improve the description of martial law by listing the number of units applying
it and the total number of citizens made happier as a result.
Greatly expand the description of military unhappiness by explaining the three
effects that come into play and providing numbers similiar to the above.

Should help with #269.
lmoureaux added a commit to lmoureaux/freeciv21 that referenced this issue Aug 9, 2022
@lmoureaux
Expand the city dialog text for wonders
115b5a6 
Improve the description by explaining which effects are active and, for two of
them, what contributes to their value (the third one is a simple binary effect,
and that's harder to display properly). Helps longturn#269.

Factor out a function to build such effect descriptions so we don't need to
repeat the same code over and over again.
lmoureaux added a commit that referenced this issue Aug 12, 2022
@lmoureaux
Expand the city dialog text for wonders
d146b8f 
Improve the description by explaining which effects are active and, for two of
them, what contributes to their value (the third one is a simple binary effect,
and that's harder to display properly). Helps #269.

Factor out a function to build such effect descriptions so we don't need to
repeat the same code over and over again.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request gui This issue requires changes to the user interface server This issue requires changes to the server
Projects
None yet
Milestone
v3.0-stable
Development

Successfully merging a pull request may close this issue.

Expand the city dialog text for wonders lmoureaux/freeciv21
3 participants
@lmoureaux @jwrober @psampathkumar