Fixes an issue where day ranges were being counted incorrectly #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing moment.js diff()
jazanne
changed the title
|
Hey @jazanne sorry, kind of missed your PR 😢 could you perform a rebase to resolve the conflicts? |
|
Nice work! |
|
@calebcauthon you seem to be "on" this issue with day counting. #379 suggested a similar changes but seem to break some functionality. Do you have the time + knowledge to dive into the use of Moment.js for this? |
|
Haven't gotten around to fully understanding the issue here but here's at least the rebased version of this fix: #423 |
|
Fixed by #423 |
|
thanks for performing the @calebcauthon! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leverages moment.js diff() to count day ranges.
Fixes issue: #310