Use moment to calculate the difference between dates #423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wakirin
reviewed
Apr 2, 2018
src/jquery.daterangepicker.js
Outdated
| @@ -1803,7 +1803,7 @@ | |||
| } | |||
|
|
|||
| function countDays(start, end) { | |||
| return Math.abs(daysFrom1970(start) - daysFrom1970(end)) + 1; | |||
| return moment(start).diff(moment(end), 'd') + 1; | |||
There was a problem hiding this comment.
Add Math.abs, because returning value can be negative;
There was a problem hiding this comment.
Also you can remove functions daysFrom1970 and toLocalTimestamp, they not required anymore.
|
Looks good to me also. |
|
@calebcauthon can you perform the suggestions made by @wakirin, then I will squash and merge... |
added 2 commits
April 3, 2018 19:31
|
Thanks for the review and suggestions! Changes are made and screenshot updated. |
This was referenced Apr 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whats New
Screenshots
Updated after suggested changes