TS: Add edges to Patterns #506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this breaking change needs to be tied to a new tsent version. don't have that yet but need to include that
lolopinto
added a commit
that referenced
this pull request
Jan 25, 2022
fixes #694 * ParseSchema() in input.go was changed in #506 to support multiple ways to parse the schema because of a breaking change. that ended up masking issues if there was an error json marshalling. considering that was a while ago, simplify by no longer supporting the old way * when nullable: false is passed, the following error is shown ``` json: cannot unmarshal bool into Go struct field Action.schemas.actions.actionOnlyFields of type input.NullableItem ``` this is because JS version of the code supports multiple types but go doesn't. update the JS schema parsing to handle when nullable: false is passed. also fix a potential other scenario this could happen with polymorphic: false * the way imports work in base file is wonky and since enum types have other imports that are needed, that wasn't being passed along created #703 to fix the issue long term. did a workaround in the code generation to import the type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TypeScript API to allow edges in Patterns.
Allows for reusable functionality e.g. feedback with likes and comments
This will be paired with corresponding change in golang
Included:
src/scripts/read_schema.tsintosrc/parse_schema/parse.tswhich can be independently testedAssocEdgeQueryBaseto take a factory method which given the nodeType returns the correct load options which will be used to load the ent. Needed to support polymorphic edges where id2 can be different typesnamein Pattern requirededgeConstNametoAssocEdgeandInverseAssocEdgeso that the developer can specify what the generated edge should be called