Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ImportType cleanup/consolidation #703

Closed
lolopinto opened this issue Jan 24, 2022 · 0 comments · Fixed by #772 or #773
Closed

ImportType cleanup/consolidation #703

lolopinto opened this issue Jan 24, 2022 · 0 comments · Fixed by #772 or #773
Labels

Comments

@lolopinto
Copy link
Owner

We have different import types which are different and broken:

lolopinto added a commit that referenced this issue Jan 25, 2022
fixes #694

* ParseSchema() in input.go was changed in #506 to support multiple ways to parse the schema because of a breaking change. that ended up masking issues if there was an error json marshalling. considering that was a while ago, simplify by no longer supporting the old way
* when nullable: false is passed, the following error is shown
```
  json: cannot unmarshal bool into Go struct field Action.schemas.actions.actionOnlyFields of type input.NullableItem
```
this is because JS version of the code supports multiple types but go doesn't. update the JS schema parsing to handle when nullable: false is passed. also fix a potential other scenario this could happen with polymorphic: false
* the way imports work in base file is wonky and since enum types have other imports that are needed, that wasn't being passed along
created #703 to fix the issue long term. did a workaround in the code generation to import the type
This was referenced Feb 27, 2022
lolopinto added a commit that referenced this issue Feb 28, 2022
more in the technical debt cleanup

uses json marshalling tricks to make it work

was added by #511

also fixes #703
lolopinto added a commit that referenced this issue Feb 28, 2022
more in the technical debt cleanup

uses json marshalling tricks to make it work

was added by #511

also fixes #703
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant