-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ImportType cleanup/consolidation #703
Labels
Comments
lolopinto
added a commit
that referenced
this issue
Jan 25, 2022
fixes #694 * ParseSchema() in input.go was changed in #506 to support multiple ways to parse the schema because of a breaking change. that ended up masking issues if there was an error json marshalling. considering that was a while ago, simplify by no longer supporting the old way * when nullable: false is passed, the following error is shown ``` json: cannot unmarshal bool into Go struct field Action.schemas.actions.actionOnlyFields of type input.NullableItem ``` this is because JS version of the code supports multiple types but go doesn't. update the JS schema parsing to handle when nullable: false is passed. also fix a potential other scenario this could happen with polymorphic: false * the way imports work in base file is wonky and since enum types have other imports that are needed, that wasn't being passed along created #703 to fix the issue long term. did a workaround in the code generation to import the type
This was referenced Feb 27, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We have different import types which are different and broken:
ent/internal/schema/node_data.go
Lines 190 to 194 in 2691971
ent/internal/enttype/type.go
Line 119 in ec7354f
ent/internal/graphql/generate_ts_code.go
Line 2469 in c818639
ent/internal/kv/pair.go
Line 9 in b4b5046
and probably not changing but flagging nonetheless)
The text was updated successfully, but these errors were encountered: