Add i18next-shopify framework #949
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkevinosullivan
changed the title
dpasiliao
reviewed
Jun 21, 2023
mkevinosullivan
force-pushed
the
kos/add_i18next_shopify_framework
branch
2 times, most recently
from
dd21ea2 to
134008a
Compare
This commit adds the `supportAutoExtraction` array of supported formats and the `detectHardStrings` method from `GeneralFramework` to enable hard-coded string extraction for react-i18next framework, without needing the "general" framework to be enabled/loaded in the `.vscode/settings.json` file.
mkevinosullivan
force-pushed
the
kos/add_i18next_shopify_framework
branch
from
134008a to
92cfeaa
Compare
This commit adds the i18next-shopify framework to the list of supported frameworks. It is an extension of the React i18next framework, with some configuration changes. Also add i18next-shopify example app, including a pluralization example.
mkevinosullivan
force-pushed
the
kos/add_i18next_shopify_framework
branch
from
2bd2073 to
e933f63
Compare
mkevinosullivan
changed the title
This was referenced Jun 23, 2023
This was referenced Jul 10, 2023
|
Merged within #970 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the
i18next-shopifyframework to the list of supported frameworks.It is an extension of the React i18next framework, with some configuration changes.
Note that this requires #951 to be merged first
Replaces #931