Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recommendation and config for i18n-ally #1284

Merged
merged 3 commits into from
Jul 11, 2023

Conversation

mkevinosullivan
Copy link
Contributor

@mkevinosullivan mkevinosullivan commented Jun 23, 2023

WHY are these changes introduced?

i18next-shopify (and associated dependencies) was recently added to this template repo (in the web/frontend folder). This commit recommends the i18n-ally VS Code extension to aide in internationalization/translation efforts.

WHAT is this pull request doing?

Adds lokalise.i18n-ally to .vscode/extensions.json file (recommendation) and adds .vscode/settings.json file with appropriate i18n-ally configuration for this template.

Note

lokalise/i18n-ally#949 needs to be merged and released before this PR can be merged.

Add recommendation of i18n-ally VS Code extension to aid in
internationalization. Also, add configuration of the extension align
with template contents.
@mkevinosullivan mkevinosullivan marked this pull request as ready for review June 23, 2023 19:02
@mkevinosullivan mkevinosullivan requested a review from a team as a code owner June 23, 2023 19:02
@mkevinosullivan mkevinosullivan merged commit 1a47892 into main Jul 11, 2023
@mkevinosullivan mkevinosullivan deleted the kos/add_recommendation_config_i18n-ally branch July 11, 2023 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants