bump version for release of #291 #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robbavey
reviewed
Jul 20, 2018
CHANGELOG.md
Outdated
| @@ -1,3 +1,6 @@ | |||
| ## 4.3.11 | |||
| - [#291](https://github.com/logstash-plugins/logstash-input-jdbc/pull/291) Fix a bug where receiving a string value that could not be converted to UTF-8 (such as BLOB data) could crash the input while attempting to log a warning. | |||
There was a problem hiding this comment.
Would you mind reformatting this to meet the Logstash Changelog formatting guidelines
There was a problem hiding this comment.
yeah. I was going for internal consistency, but global consistency moving forward is better. 👍
yaauie
force-pushed
the
charset-converter-logger-release
branch
from
da76e4a to
ddb6712
Compare
robbavey
reviewed
Jul 20, 2018
CHANGELOG.md
Outdated
| @@ -1,3 +1,6 @@ | |||
| ## 4.3.11 | |||
| - Fix crash that occurs when receiving string input that cannot be coerced to UTF-8 (such as BLOB data) [#291](https://github.com/logstash-plugins/logstash-input-jdbc/pull/291) | |||
There was a problem hiding this comment.
Super nit: Action word should be in the past tense
Feel free to merge after changing that
yaauie
force-pushed
the
charset-converter-logger-release
branch
from
ddb6712 to
862667c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
d'oh. I should have bumped for release in #291.