connect our logger up to the charset converters #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `LogStash::Util::Charset` utility will attempt to send a `warn` to its `@logger` instance variable when it encounters invalid encoding, but does not take a logger to its constructor. Failing to wire up a logger means that each time we attempt to convert a string and fail to arrive at valid UTF-8, we send `warn` to `NilClass`, which raises a `NoMethodError`.
yaauie
added a commit
to yaauie/logstash-input-jdbc
that referenced
this pull request
Jul 20, 2018
yaauie
added a commit
to yaauie/logstash-input-jdbc
that referenced
this pull request
Jul 20, 2018
yaauie
added a commit
to yaauie/logstash-input-jdbc
that referenced
this pull request
Jul 21, 2018
yaauie
added a commit
that referenced
this pull request
Jul 23, 2018
bump version for release of #291
|
An unknown error occurred sending a bulk request to Elasticsearch (will retry indefinitely) {:message=>""\xFF" from ASCII-8BIT to UTF-8", :exception=>LogStash::Json::GeneratorError, :backtrace=>["/Users/manzoorfaisal/Desktop/Laptop-Migration-2/logstash-7.17.4/logstash-core/lib/logstash/json.rb:43:in can you please me to out from this issue? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
LogStash::Util::Charsetutility will attempt to send awarnto its@loggerinstance variable when it encounters invalid encoding, but does nottake a logger to its constructor.
Failing to wire up a logger means that each time we attempt to convert a string
and fail to arrive at valid UTF-8, we send
warntoNilClass, which raisesa
NoMethodError.