Kibana/Elasticsearch/Python Setup and Auto-Export #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
April 4, 2016 12:27
…ptForInserting Conflicts: packaging/kibana.spec
added 7 commits
April 25, 2016 17:03
documents, doesnt do full Dashboard parsing yet
scripts with some minor tweaking
| return asset_title + ".json" | ||
|
|
||
| def get_full_path(asset_id): | ||
| global OUTPUT_DIR |
There was a problem hiding this comment.
Don't make this change now, but so many global variables almost warrants this to be a class.
There was a problem hiding this comment.
Okay I will make a note of that for next time
| import elasticsearch | ||
|
|
||
| class Logger: | ||
| MAIN_LOG_FORMAT_STR='%(asctime)s.%(msecs)03d %(levelname)s: %(message)s' |
There was a problem hiding this comment.
It looks like you tab with two spaces here but four in other files. Try to keep it consistent, but that can be done in the same PR you make the other file (that Shweta mentioned) a class.
|
👍 |
|
|
||
| def get_full_path(asset_id): | ||
| global OUTPUT_DIR | ||
| if OUTPUT_DIR[-1:] == '/': |
There was a problem hiding this comment.
I don't think you need the colon here. I think OUTPUT_DIR[-1] should work. You can ask Dan or Shweta, they would know better. But if you're trying to get the last element of the list, there shouldn't be a need to splice it.
craig-cogdill
added a commit
that referenced
this pull request
May 3, 2016
[MERGE WITH #39] Fixed filters in dashboard
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did these 2 cards in one PR, because I did some refactoring in Stage 2 that effected the code from Stage 1.
setDefaultIndex.pysets up the index-pattern as[network_]YYYY_MM_DDand makes it the default index-pattern used by Kibana for displaying metadata info (sidenote: this will be really easy to extend to our other ES index patterns once we decide to open them up like Alex showed in his demo)loadAssets.pyloads all of our dashboards, visualizations, and searches into ES, or updates them if the version in ES is older than the one currently installed on disk.exportAssets.pyis the script used to modify dashboards, visualizations, and searches so that they are exported in the right form for PRs. Just runpython exportAssets.py --helpfor info on how it is used.