[MERGE WITH #39] Fixed filters in dashboard #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@acarb95 why all the file renames/version changes? is that how @craig-cogdill said to do versioning? |
| @@ -2,7 +2,7 @@ | |||
| "title": "Top 10 Email Sender Domains", | |||
| "visState": "{\"type\":\"pie\",\"params\":{\"shareYAxis\":true,\"addTooltip\":true,\"addLegend\":true,\"isDonut\":false},\"aggs\":[{\"id\":\"1\",\"type\":\"count\",\"schema\":\"metric\",\"params\":{}},{\"id\":\"2\",\"type\":\"terms\",\"schema\":\"segment\",\"params\":{\"field\":\"SenderDomain.raw\",\"size\":10,\"order\":\"desc\",\"orderBy\":\"1\"}}],\"listeners\":{}}", | |||
| "description": "", | |||
| "version": 1, | |||
| "version": 2, | |||
There was a problem hiding this comment.
Don't need to update this version since this visualization hasn't changed
|
This should actually get merged AFTER my PR in Kibana for redo-ing the python scripts for inserting everything. It'll allow us to test more accurately with all the version changes. |
|
Okay! I'll add that to the title. |
acarb95
changed the title
|
Looks like it works great on 190. Doesn't necessarily have to be merged AFTER the other one, but they should be merged on the same day so that they're both in a build |
|
👍 |
acarb95
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed File Reconstruction Dashboard and SMTP Trends dashboard to use filters instead of a specific search in the visualization. Ran on VM (didn't have SMTP or File Recon traffic) and the filters were there.
Please pull down and double check that it works on a system with SMTP and File Recon traffic.
Also fixed Top 10 Attachment Types (bar graph), it was displaying more than the top 10.
Merge after Craig's PR: #39