fix: add support for "host:port" forwardPorts syntax #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for devpod-docs canceled.
|
lizardruss
force-pushed
the
forward-port-syntax
branch
3 times, most recently
from
24d7db2 to
fad948e
Compare
lizardruss
commented
May 19, 2023
pkg/devcontainer/config/config.go
Outdated
| @@ -354,3 +355,55 @@ func (m *Mount) UnmarshalJSON(data []byte) error { | |||
| } | |||
| return types.ErrUnsupportedType | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
found StrIntArray after implementing this.. I can refactor if desired.
FabianKramm
requested changes
May 22, 2023
There was a problem hiding this comment.
@lizardruss thanks for the PR! Yeah please use types.StrIntArray instead, like we do for AppPort
lizardruss
force-pushed
the
forward-port-syntax
branch
from
fad948e to
98d0668
Compare
FabianKramm
approved these changes
May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #305
Fixes ENG-1420