Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

forwardPorts not support "host:port" syntax #305

Closed
mrdev023 opened this issue May 17, 2023 · 1 comment · Fixed by #327
Closed

forwardPorts not support "host:port" syntax #305

mrdev023 opened this issue May 17, 2023 · 1 comment · Fixed by #327
Assignees

Comments

@mrdev023
Copy link

mrdev023 commented May 17, 2023

What happened?

When i try to use "[service_name]:[port]" with docker-compose config. I get json: invalid number literal, trying to unmarshal "\"db:5432\"" into Number

See https://containers.dev/implementors/json_reference/#general-properties

How can we reproduce the bug? (as minimally and precisely as possible)

My devcontainer.json:

{
    ...
    "forwardPorts": [
        3000,
        "db:5432"
    ],
    ...
}

Local Environment:

  • DevPod Version: v0.1.4
  • Operating System: linux
  • ARCH of the OS: AMD64

DevPod Provider:

  • Local/remote provider: docker
@FabianKramm
Copy link
Member

@mrdev023 thanks a lot for the issue! Oh true, seems like we missed that that is possible as well, should be an easy fix, we will fix that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants