ESP-IDF Release v4.0 Support & Open PR Consolidation #79
+1,344
−979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: #2
Adds the TTGO T-Display to the Kconfig system. Changes taken from: Xinyuan-LilyGO/TTGO-T-Display#8
Ttgo t display support & new IDF compatibility
This adds a define, that the program can use, if the display needs to be inverted by default.
This adds offsets for displays that put 0;0 outside the actual screen area. The additional calculations completely dissapear when not defining any offsets, thus eliminating any potential performance hits for displays that do not need offsets.
Adding offset and inversion handling
… include path For more information about how component requirements are declared, see https://docs.espressif.com/projects/esp-idf/en/v4.0.1/api-guides/build-system.html#component-requirements Closes #8
…ncies cmake: Declare nvs_flash as a dependency, instead of pushing include path
Adding support for the TTGO T-WRISTBAND support
Change string parameters to be const char * (instead of char*) and fix up related spacing and formatting.
Fix various typos and make punctuation consistent.
Fix const correctness in TFT functions
Fix typos in README
warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
Add const qualifier to temp pointer to fix warning
tftspi.h is not meant to be a separate public interface because it is already included in `tft.h`. See discussion in #15; `tftspi.h` is not a useful interface on it is own; user programs should include only `tft.h`.
Fixes for compiling with esp-idf v5.0
esp-idf v5.1 have deprecated the legacy spi_flash APIs, so using the newer APIs if esp-idf version is >= 5.0
Use the newer spi_flash APIs for read/write/erase flash operations
- typecast for fixing the type - remove IRAM_ATTR for getting rid of conflic warnings - fix use after free
Fix warnings when building with esp-idf v5.2.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've merged all of the open PRs in my branch, but also contributed some changes to make this library compatible with the latest changes in ESP-IDF and fully configurable through
idf.py menuconfig.I'm hopeful this could be merged into the upstream repository but I'll also continue to take PRs at https://github.com/jeremyjh/ESP32_TFT_library .
Other than required updates for 4.0, the motivation for these changes is to improve the usability of this repo as an ESP library component rather than the basis of a new project.
This now builds its subcomponents with
idf_register_component. Instructions for including as a library to an existing project have been added, along with updates for building and running the examples withidf.py.All the configuration that is relevant to using this project as a library (e.g. SPIFFs, predefined screen configs) have been moved into the component folders, rather than being configured in the Demo project.
It is now possible to configure all the pins individually through menuconfig, and instructions about modifying the headers directly have been removed.
I also prefixed all global variables with
tft_that were not already so prefixed. This is perhaps the biggest breaking change for existing users, but I feel it is for the best as it makes usage of these variables in application code much more obvious, and reduces the possibility of name collision with other libraries.The other breaking change is the renaming of the Example configs. These were already used in the library proper and referred to as predefines so I updated the name itself to reflect that along with moving them into the library's Kconfig. To update, users just need to run
idf.py menuconfig.