Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make behavior consistent when equipping slotfully and slotlessly #92

Merged
merged 2 commits into from
Jun 22, 2023
Merged

Make behavior consistent when equipping slotfully and slotlessly #92

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6bc2a28
Make behavior consistent when equipping slotfully and slotlessly
s-k-z May 22, 2023
1726921
Just compare to zero
s-k-z May 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/outfit.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,6 +352,9 @@ export class Outfit {
* @returns True if one of the things is equipped, and false otherwise.
*/
public equipFirst(things: Item[] | Familiar[], slot?: Slot): boolean {
// some() returns false on an empty array, yet every() returns true.
// This keeps behavior consistent between slotful and slotless equipping.
if (things.length < 1) return true;
return things.some((val) => this.equip(val, slot));
}

Expand Down