Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make behavior consistent when equipping slotfully and slotlessly #92

Merged
merged 2 commits into from
Jun 22, 2023

Conversation

s-k-z
Copy link
Contributor

@s-k-z s-k-z commented May 22, 2023

Somewhat unexpected behavior:

> js [].every((e)=>true);

Returned: true

> js [].some((e) => true);

Returned: false

By short circuiting this we get consistent equipping success/failure for both equipping an empty array with and without a slot specified.

@Kasekopf Kasekopf merged commit 32651df into main Jun 22, 2023
@Kasekopf Kasekopf deleted the skip-empty-array-outfits branch June 22, 2023 05:25
@Kasekopf
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants