Revert "Revert updating mlir_native_functions.cpp signature" #1292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit a1ace06.
ashay
approved these changes
Aug 26, 2022
|
Closing, since #1289 includes these changes |
|
looks like we need to revert the revert of the revert again ? |
|
@antoniojkim Could you look into this? This change was added back in your PR #1289 |
|
Maybe if we wait long enough, this reversion will also get reverted 😝 |
powderluv
added a commit
that referenced
this pull request
Aug 29, 2022
* Disable LTC by default until upstream revert relands Tracked with the WIP #1292 * Disable LTC e2e tests temporarily * Update setup.py Disable LTC in setup.py temporarily until upstream is fixed.
qedawkins
pushed a commit
to nod-ai/torch-mlir
that referenced
this pull request
Oct 3, 2022
Signed-off-by: Whitney Tsang <[email protected]>
qedawkins
pushed a commit
to nod-ai/torch-mlir
that referenced
this pull request
Oct 3, 2022
The modification to use the builder based interface to generate Krnl loop is completed (llvm#1250, llvm#1283, llvm#1285, llvm#1292, llvm#1293, llvm#1303, llvm#1308, llvm#1314, llvm#1316, llvm#1317, llvm#1326, llvm#1403), and BuildKrnlLoop is no longer needed. Signed-off-by: Whitney Tsang [email protected]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #1281 and unblocks CI failure from updated LTC API + tests
It looks like the revert of the PyTorch PR got reverted... pytorch/pytorch@9790d90