-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a CI test to validate shapelib #1317
Comments
Is there a way that we can avoid duplicating the tests in build_linux_packages.sh and buildAndTest.yml? It seems redundant to specify in both. |
There should be no tests in buildAndTest.yml (for linux). |
So I would like to understand what is the expected behaviour of the test so we slot it in correctly: When do you expect there to be a valid difference to fail the build ? If latest PyTorch was updated we fail the local CI and ask the developer to update shape / torch ? |
Yes. For now, it will be like any breaking PyTorch change -- it will cause local builds to fail. The solution is to have a deliberate weekly PyTorch bump. |
#1328 to track the periodic PyTorch bump |
…l loops (llvm#1317) [LRN][Pooling][Loop] Use builder based interface to generate Krnl loops (Only partially done) Signed-off-by: Whitney Tsang <[email protected]>
The modification to use the builder based interface to generate Krnl loop is completed (llvm#1250, llvm#1283, llvm#1285, llvm#1292, llvm#1293, llvm#1303, llvm#1308, llvm#1314, llvm#1316, llvm#1317, llvm#1326, llvm#1403), and BuildKrnlLoop is no longer needed. Signed-off-by: Whitney Tsang [email protected]
We centralized this all to build_linux_packages.sh |
Currently CI has a test to
The text was updated successfully, but these errors were encountered: