Allow expanding and collapsing in aten::view #1082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qedawkins
force-pushed
the
view-expand-collapse
branch
from
452905f to
0250a70
Compare
|
Also @silvasean is there a place I can request write access? This seemed like the best channel to ask in. |
ramiro050
requested changes
Jul 19, 2022
qedawkins
force-pushed
the
view-expand-collapse
branch
from
0250a70 to
c872f05
Compare
Added you! |
ramiro050
requested changes
Jul 20, 2022
qedawkins
force-pushed
the
view-expand-collapse
branch
from
c872f05 to
82f0574
Compare
- Supports cases where the view op expands and collapses dims simulataneously. This does not handle the case where it is neither expanding nor collapsing (e.g. [2, 3] -> [3, 2]) - Additionally fixes a previous bug with adding 1-sized dims on both sides of a tensor with aten.view
qedawkins
force-pushed
the
view-expand-collapse
branch
from
82f0574 to
244ba2e
Compare
|
Thanks for the comments! Let me know if it looks like there are still issues. |
gpetters94
pushed a commit
to gpetters94/mlir-npcomp
that referenced
this pull request
Jul 27, 2022
- Supports cases where the view op expands and collapses dims simulataneously. This does not handle the case where it is neither expanding nor collapsing (e.g. [2, 3] -> [3, 2]) - Additionally fixes a previous bug with adding 1-sized dims on both sides of a tensor with aten.view
qedawkins
pushed a commit
to nod-ai/torch-mlir
that referenced
this pull request
Oct 3, 2022
* minor edit for the docs/mnist_example Signed-off-by: Alexandre Eichenberger <[email protected]> * additional output Signed-off-by: Alexandre Eichenberger <[email protected]> * responding to suggestions Signed-off-by: Alexandre Eichenberger <[email protected]> * added recommended -O3 option Signed-off-by: Alexandre Eichenberger <[email protected]> Co-authored-by: Tung D. Le <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
simultaneously. This does not handle the case where it is neither
expanding nor collapsing (e.g. [2, 3] -> [3, 2])
sides of a tensor with aten.view