Skip to content

Commit

Permalink
Allow expanding and collapsing in aten::view
Browse files Browse the repository at this point in the history
 - Supports cases where the view op expands and collapses dims
simulataneously. This does not handle the case where it is neither
expanding nor collapsing (e.g. [2, 3] -> [3, 2])
 - Additionally fixes a previous bug with adding 1-sized dims on both
sides of a tensor with aten.view
  • Loading branch information
qedawkins committed Jul 20, 2022
1 parent 7f08169 commit 244ba2e
Show file tree
Hide file tree
Showing 3 changed files with 354 additions and 150 deletions.
2 changes: 2 additions & 0 deletions e2e_testing/torchscript/xfail_sets.py
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,8 @@
"ViewExpandOnesModule_basic",
"ViewExpandOnesBeforeAndAfterModule_basic",
"ViewExpandOnesMiddleModule_basic",
"ViewExpandCollapseModule_basic",
"ViewExpandCollapseWithOnesModule_basic",
"ViewCollapseInferredDimModule_basic",
"ViewExpandInferredDimModule_basic",
"ViewNoChangeStaticModule_basic",
Expand Down
Loading

0 comments on commit 244ba2e

Please sign in to comment.