Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document frunk_core dependency requirement for [Labelled]Generic #219

Merged
merged 1 commit into from
Jul 4, 2023
Merged

Document frunk_core dependency requirement for [Labelled]Generic #219

merged 1 commit into from
Jul 4, 2023

Conversation

dima-starosud
Copy link
Contributor

@dima-starosud dima-starosud commented Jul 4, 2023 •
edited
Loading

  • Add a few words to the README that in order to derive the trait Generic (or LabelledGeneric) one has to add frunk_core dependency.

@dima-starosud dima-starosud mentioned this pull request Jul 4, 2023
Closed
lloydmeta
lloydmeta approved these changes Jul 4, 2023
View reviewed changes
Copy link
Owner

@lloydmeta lloydmeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks !

@lloydmeta lloydmeta merged commit 83b26a1 into lloydmeta:master Jul 4, 2023
@dima-starosud dima-starosud deleted the feature/document-frunk_core-requirement branch July 4, 2023 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lloydmeta lloydmeta lloydmeta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dima-starosud @lloydmeta