The correct way of adding the crate frunk dependency

[dima-starosud]

Most likely the issue is related to possibly outdated documentation.

Using rustc 1.70.0 (90c541806 2023-05-31) and following the latest docs here https://docs.rs/frunk/latest/frunk/
I've added frunk = "0.4.2" to the Cargo.toml, but the following code fails to compile:

use frunk::prelude::*;
use frunk::LabelledGeneric;

#[derive(LabelledGeneric)]
struct Zho {}

with the error:

error[E0433]: failed to resolve: could not find `frunk_core` in the list of imported crates
 --> src/main.rs:4:10
  |
4 | #[derive(LabelledGeneric)]
  |          ^^^^^^^^^^^^^^^ could not find `frunk_core` in the list of imported crates
  |
  = note: this error originates in the derive macro `LabelledGeneric` (in Nightly builds, run with -Z macro-backtrace for more info)

Adding frunk_core = "0.4.2" to the Cargo.toml fixes the issue, but I am not sure that's the proper way. Also, I couldn't find anything in the documentation about this.

To me it looks like sole frunk = "0.4.2" should work out of the box.

[lloydmeta]

I think you'll need to pull in frunk_core, unfortunately in order for the derive to work, since it's referenced in the macro that builds the derives.

frunk/derives/src/derive_labelled_generic.rs

Line 107 in 34ba13d

impl #impl_generics ::frunk_core::labelled::LabelledGeneric for #name #ty_generics #where_clause {

[dima-starosud]

Thank you for the response 👍
Do you think we should put this in the doc? i.e. deriving Generic/LabelledGeneric is probably the first prerequisite to use the lib, and to do that one should always pull frunk_core, but docs don't say anything about this.

[lloydmeta]

Thank you for the response 👍 Do you think we should put this in the doc? i.e. deriving Generic/LabelledGeneric is probably the first prerequisite to use the lib, and to do that one should always pull frunk_core, but docs don't say anything about this.

That sounds good to me !

[dima-starosud]

Cool 👍 Should I create a PR for this?

[lloydmeta]

Yeah, sounds good to me.

…

On Mon, Jul 3, 2023 at 20:12 dima-starosud ***@***.***> wrote: Cool 👍 Should I create a PR for this? — Reply to this email directly, view it on GitHub <#218 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAG7K5I5P4WUUIXJ7DGK2Q3XOKSIZANCNFSM6AAAAAAZVNEGIU> . You are receiving this because you commented.Message ID: ***@***.***>

[dima-starosud]

I am not sure I am able to assign this ticket to me 🤔

[dima-starosud]

@lloydmeta created PR for this #219
Please have a look.

[dima-starosud]

Thank you! That was fast 😃