Fix server hang/crash on admin deletion #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahmedkrmn
force-pushed
the
admin-signout
branch
from
27559c0 to
7a4ee96
Compare
Disallow currently logged in admin from deleting their own account and display an error message.
ahmedkrmn
force-pushed
the
admin-signout
branch
from
7a4ee96 to
ceeda69
Compare
ahmedkrmn
changed the title
|
Thanks. Nice fix. |
NikhilM98
added a commit
to NikhilM98/sugarizer-server
that referenced
this pull request
Mar 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #82
Disallow currently logged in admin from deleting their own account and display an error message. Details on the issue page.
This crash is caused by inconsistencies between the cookies and the stored user session when the logged in admin deletes his/her account.