Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server hangs/crashes on when an admin delete its own account #82

Closed
ahmedkrmn opened this issue Mar 10, 2019 · 3 comments
Closed

Server hangs/crashes on when an admin delete its own account #82

ahmedkrmn opened this issue Mar 10, 2019 · 3 comments

Comments

@ahmedkrmn
Copy link
Contributor

ahmedkrmn commented Mar 10, 2019

When the currently logged in admin user deletes their account, the server hangs and the page is stuck on reload until it crashes.

Problem:

admin logout

Fix: #83

Disallow currently logged in admin from deleting their own account and display an error message.

delete admin

@llaske
Copy link
Owner

llaske commented Mar 10, 2019

It's true but it's a borderline case: the admin remove himself.
Plus we're planning to create a Teacher profile avoid this sort of issue.

@llaske llaske added the bug label Mar 10, 2019
@llaske llaske changed the title Server hangs/crashes on when logged in admin signs out Server hangs/crashes on when an admin delete its own account Mar 10, 2019
@ahmedkrmn
Copy link
Contributor Author

@llaske Shall I close the PR then ?!
I think we can go with the bug fix #83 until we create the teacher profile.

@llaske
Copy link
Owner

llaske commented Mar 12, 2019

No, I've merged your fix. Thanks.

@llaske llaske added this to the v1.1 milestone Jul 9, 2019
@llaske llaske closed this as completed Jul 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants