Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add curl to images #161

Merged

Conversation

simon-swanson-leapyear
Copy link
Contributor

From #159.

curl is a super valuable tool to have available for debugging and execution, as certain Terraform modules assume the tool is available on the system. wget is less common on systems and most tools assume the existence of curl before wget.

Curl is a super valuable tool to have available for debugging and
execution, as certain Terraform modules assume the tool is available on
the system. Wget is less common on systems and most tools assume the
existence of curl before wget.

For example: wait_for_cluster_command in CloudPosse's EKS cluster module
uses curl by default. While this can be overridden to use wget, not all
the environments we run Terraform in have wget installed and we would
prefer to not introduce a bunch of conditional logic:
https://github.com/cloudposse/terraform-aws-eks-cluster/blob/783799fa64f20cde64ae19e74e046263072c8595/variables.tf#L142
Copy link

@james-pollard-leapyear james-pollard-leapyear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ljfranklin ljfranklin merged commit 5f74123 into ljfranklin:master Sep 2, 2021
@simon-swanson-leapyear simon-swanson-leapyear deleted the issue-159/swan/add-curl branch September 2, 2021 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants