Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Install curl on images #159

Open
simon-swanson-leapyear opened this issue Aug 25, 2021 · 2 comments
Open

[Feature Request] Install curl on images #159

simon-swanson-leapyear opened this issue Aug 25, 2021 · 2 comments

Comments

@simon-swanson-leapyear
Copy link
Contributor

Theoretically this is as easy as adding curl to the apk add ... commands in the Dockerfiles.

curl is a super valuable tool to have available for debugging and execution, as certain Terraform modules assume the tool is available on the system. wget is less common on systems and most tools assume the existence of curl before wget.

For example: wait_for_cluster_command in CloudPosse's EKS cluster module uses curl by default. While this can be overridden to use wget, not all the environments we run Terraform in have wget installed and we would prefer to not introduce a bunch of conditional logic.

Attaching a patch file with how this could look:
0001-Add-curl-to-images.patch.tar.gz

@ljfranklin
Copy link
Owner

SGTM, please open a PR and I'll be happy to approve.

@simon-swanson-leapyear
Copy link
Contributor Author

Sorry for the wait, I apparently need to update my email filters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants