Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#500 - Popover - onClose prop to pass handler for popover close action #501

Merged
merged 3 commits into from
Feb 21, 2023

Conversation

marcinsawicki
Copy link
Contributor

@marcinsawicki marcinsawicki commented Feb 20, 2023

Resolves: #500

Description

A simple change that will allow passing the handler to be fired when Popover closes.
No tests and stories update at this moment, because component will be updated in the future.

Storybook

https://feature-500--613a8e945a5665003a05113b.chromatic.com/

Checklist

Obligatory:

  • Self-review
  • Unit & integration tests
  • Storybook cases
  • Design review
  • Functional (QA) review

Optional:

  • Accessibility cases (keyboard control, correct HTML markup, etc.)

@marcinsawicki marcinsawicki added the feature New feature or request label Feb 20, 2023
@marcinsawicki marcinsawicki linked an issue Feb 21, 2023 that may be closed by this pull request
@marcinsawicki marcinsawicki merged commit 3461958 into v1 Feb 21, 2023
@marcinsawicki marcinsawicki deleted the feature/500 branch February 21, 2023 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Popover] Add onClose handler
2 participants