Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Popover] Add onClose handler #500

Closed
michalv8 opened this issue Feb 20, 2023 · 0 comments · Fixed by #501
Closed

[Popover] Add onClose handler #500

michalv8 opened this issue Feb 20, 2023 · 0 comments · Fixed by #501
Assignees
@marcinsawicki
Labels
feature New feature or request

Comments

@michalv8
Copy link
Contributor

michalv8 commented Feb 20, 2023 •
edited
Loading

Description

Add onClose handler to be able to synchronize state of Popover with userland.
@michalv8 michalv8 converted this from a draft issue Feb 20, 2023
@michalv8 michalv8 added the feature New feature or request label Feb 20, 2023
@marcinsawicki marcinsawicki moved this to In Progress in LiveChat Design System Feb 20, 2023
@marcinsawicki marcinsawicki self-assigned this Feb 20, 2023
@marcinsawicki marcinsawicki added this to the v1.0.0 milestone Feb 20, 2023
@marcinsawicki marcinsawicki mentioned this issue Feb 20, 2023
Merged
6 tasks
@marcinsawicki marcinsawicki moved this from In Progress to In Review in LiveChat Design System Feb 20, 2023
@marcinsawicki marcinsawicki linked a pull request Feb 21, 2023 that will close this issue
#500 - Popover - onClose prop to pass handler for popover close action #501
Merged
6 tasks
marcinsawicki added a commit that referenced this issue Feb 21, 2023
@marcinsawicki
#500 - Popover - onClose prop to pass handler for popover close action (
3461958 
#501)

* added onClose prop to pass handler for popover close action

* test commit

* test commit
@marcinsawicki marcinsawicki moved this from In Review to Done in LiveChat Design System Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marcinsawicki marcinsawicki

Labels
feature New feature or request
Projects
LiveChat Design System
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#500 - Popover - onClose prop to pass handler for popover close action livechat/design-system
2 participants
@michalv8 @marcinsawicki