Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#451 - Alert - Possibility to pass additional props (like data-testid) to the component #497

Merged
merged 1 commit into from
Feb 17, 2023
Merged

#451 - Alert - Possibility to pass additional props (like data-testid) to the component #497

merged 1 commit into from
Feb 17, 2023

Conversation

marcinsawicki
Copy link
Contributor

@marcinsawicki marcinsawicki commented Feb 15, 2023 •
edited
Loading

Resolves: #451

Description

Possibility to pass additional props (like data-testid) to the component.

Storybook

https://feature-451--613a8e945a5665003a05113b.chromatic.com/

Checklist

Obligatory:

  • Self-review
  • Unit & integration tests
  • Storybook cases
  • Design review
  • Functional (QA) review

Optional:

  • Accessibility cases (keyboard control, correct HTML markup, etc.)

@marcinsawicki marcinsawicki added the bug Something isn't working label Feb 15, 2023
@marcinsawicki marcinsawicki linked an issue Feb 15, 2023 that may be closed by this pull request
[Alert] Add possibility to pass the data-testid prop to the component #451
Closed
@marcinsawicki marcinsawicki merged commit b921c19 into v1 Feb 17, 2023
@marcinsawicki marcinsawicki deleted the feature/451 branch February 17, 2023 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichalPaszowski MichalPaszowski MichalPaszowski approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
LiveChat Design System
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Alert] Add possibility to pass the data-testid prop to the component
2 participants
@marcinsawicki @MichalPaszowski