Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Alert] Add possibility to pass the data-testid prop to the component #451

Closed
marcinsawicki opened this issue Nov 24, 2022 · 0 comments · Fixed by #497
Closed

[Alert] Add possibility to pass the data-testid prop to the component #451

marcinsawicki opened this issue Nov 24, 2022 · 0 comments · Fixed by #497
Assignees
@marcinsawicki
Labels
bug Something isn't working

Comments

@marcinsawicki
Copy link
Contributor

Currently using the component in the application prevents us from passing the data-testid to testsit for the visibility of the component.
@marcinsawicki marcinsawicki added the feature New feature or request label Nov 24, 2022
@marcinsawicki marcinsawicki moved this from Backlog to In Progress in LiveChat Design System Feb 15, 2023
@marcinsawicki marcinsawicki self-assigned this Feb 15, 2023
@marcinsawicki marcinsawicki added this to the v1.0.0 milestone Feb 15, 2023
@marcinsawicki marcinsawicki moved this from In Progress to In Review in LiveChat Design System Feb 15, 2023
@marcinsawicki marcinsawicki added bug Something isn't working and removed feature New feature or request labels Feb 15, 2023
@marcinsawicki marcinsawicki mentioned this issue Feb 15, 2023
Merged
6 tasks
@marcinsawicki marcinsawicki linked a pull request Feb 15, 2023 that will close this issue
#451 - Alert - Possibility to pass additional props (like data-testid) to the component #497
Merged
6 tasks
marcinsawicki added a commit that referenced this issue Feb 17, 2023
@marcinsawicki
#451 - Alert - Possibility to pass additional props (like data-testid…
b921c19 
…) to the component (#497)

pass additional props (like data-testid) to the component
@marcinsawicki marcinsawicki moved this from In Review to Done in LiveChat Design System Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marcinsawicki marcinsawicki

Labels
bug Something isn't working
Projects
LiveChat Design System
Archived in project
Milestone
No milestone
1 participant
@marcinsawicki