Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#343 Extend the Picker options interface and logic to enable passing the own component as item #450

Merged
merged 3 commits into from
Dec 9, 2022
Merged

#343 Extend the Picker options interface and logic to enable passing the own component as item #450

merged 3 commits into from
Dec 9, 2022

Conversation

marcinsawicki
Copy link
Contributor

@marcinsawicki marcinsawicki commented Nov 15, 2022 •
edited
Loading

Resolves: #343

Description

Some changes related to the interface and logic of Trigger and PickerList, enabling the possibility to pass the own component as list item.

Storybook

Storybook

Checklist

Obligatory:

  • Self-review
  • Unit & integration tests
  • Storybook cases
  • Design review
  • Functional (QA) review

Optional:

  • Accessibility cases (keyboard control, correct HTML markup, etc.)

@marcinsawicki marcinsawicki linked an issue Nov 15, 2022 that may be closed by this pull request
[Picker] List items should have possibility to put own component there #343
Closed
@marcinsawicki marcinsawicki added the feature New feature or request label Nov 15, 2022
@marcinsawicki marcinsawicki changed the title #343 Extend the Picker options interface and logic to enable passing the component as list item #343 Extend the Picker options interface and logic to enable passing the own component as item Nov 15, 2022
sgraczyk
sgraczyk approved these changes Nov 18, 2022
View reviewed changes
Copy link

@sgraczyk sgraczyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved however, it would be nice to introduce some simple tests.

@marcinsawicki marcinsawicki merged commit e9f2047 into v1 Dec 9, 2022
@marcinsawicki marcinsawicki deleted the feature/343-v2 branch December 9, 2022 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kstvsko kstvsko kstvsko approved these changes

@jpyzio123 jpyzio123 jpyzio123 approved these changes

@sgraczyk sgraczyk sgraczyk approved these changes

@MichalPaszowski MichalPaszowski MichalPaszowski approved these changes

Assignees
No one assigned
Labels
feature New feature or request
Projects
LiveChat Design System
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Picker] List items should have possibility to put own component there
5 participants
@marcinsawicki @MichalPaszowski @sgraczyk @jpyzio123 @kstvsko