Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Picker] List items should have possibility to put own component there #343

Closed
marcinsawicki opened this issue Jul 14, 2022 · 0 comments · Fixed by #450
Closed

[Picker] List items should have possibility to put own component there #343

marcinsawicki opened this issue Jul 14, 2022 · 0 comments · Fixed by #450
Assignees
@marcinsawicki
Labels
feature New feature or request
Milestone
DS Beta

Comments

@marcinsawicki
Copy link
Contributor

marcinsawicki commented Jul 14, 2022 •
edited
Loading

Description

Currently, the Picker only takes the item's name to select and displays plain text in the items list.
This functionality should be expanded to allow displaying the component as a list item (e.g. an avatar with the username).
The same functionality must be available in multi-select mode, but components should be displayed also as selected item tags.
@marcinsawicki marcinsawicki added the feature New feature or request label Jul 14, 2022
@sgraczyk sgraczyk added this to the Future plans milestone Jul 19, 2022
@marcinsawicki marcinsawicki moved this from Backlog to Selected for Development in LiveChat Design System Jul 26, 2022
@marcinsawicki marcinsawicki self-assigned this Jul 26, 2022
@marcinsawicki marcinsawicki mentioned this issue Jul 27, 2022
Closed
6 tasks
@marcinsawicki marcinsawicki linked a pull request Jul 27, 2022 that will close this issue
#343 Extend the Picker options interface and logic to enable passing the component as list item #362
Closed
6 tasks
@marcinsawicki marcinsawicki moved this from Selected for Development to In Progress in LiveChat Design System Jul 27, 2022
@marcinsawicki marcinsawicki mentioned this issue Nov 15, 2022
Merged
6 tasks
@marcinsawicki marcinsawicki linked a pull request Nov 15, 2022 that will close this issue
#343 Extend the Picker options interface and logic to enable passing the own component as item #450
Merged
6 tasks
@marcinsawicki marcinsawicki moved this from In Progress to In Review in LiveChat Design System Nov 15, 2022
marcinsawicki added a commit that referenced this issue Dec 9, 2022
@marcinsawicki
#343 Extend the Picker options interface and logic to enable passing …
e9f2047 
…the own component as item (#450)

* custom component as item body

* more tests related to custom components passed as options
@marcinsawicki marcinsawicki moved this from In Review to Done in LiveChat Design System Dec 9, 2022
@VadymBezpalko VadymBezpalko modified the milestones: Future plans, DS Beta Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marcinsawicki marcinsawicki

Labels
feature New feature or request
Projects
LiveChat Design System
Archived in project
Milestone
DS Beta
3 participants
@sgraczyk @VadymBezpalko @marcinsawicki