#332 z-index for Popover component #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichalPaszowski
changed the title
sgraczyk
reviewed
Aug 29, 2022
| @@ -5,6 +5,7 @@ | |||
| display: none; | |||
| max-width: 336px; | |||
| min-width: 168px; | |||
| z-index: 1000; | |||
There was a problem hiding this comment.
Could we use a dedicated variable from
https://github.com/livechat/design-system/blob/39fcca44937242ba3bd3bc7c8b855269d335b2f1/packages/react-components/src/utils/StackingContextLevel.scss
I believe we would need to introduce a new level:
W could follow this concept from LiveChat's Agent App:
export enum StackingContextLevel {
Tooltip = 1000,
Dropdown = 2000,
...
}
This was
linked to
issues
Aug 30, 2022
jpyzio123
approved these changes
Sep 5, 2022
sgraczyk
reviewed
Sep 5, 2022
| @@ -5,6 +5,7 @@ | |||
| display: none; | |||
| max-width: 336px; | |||
| min-width: 168px; | |||
| z-index: $stacking-context-level-popover; | |||
There was a problem hiding this comment.
You need to import it before usage @import '../../utils/StackingContextLevel';
sgraczyk
requested changes
Sep 5, 2022
sgraczyk
approved these changes
Sep 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #332
Description
It seems to be enough to fix stuff like:
https://monosnap.com/file/agb5EyL9CrbJqO8E0vNQhtUAo6BYOo
Storybook
https://613a8e945a5665003a05113b-iaeypnmfan.chromatic.com/
Checklist
Obligatory:
Optional: